[ 
https://issues.apache.org/jira/browse/ARIA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036321#comment-16036321
 ] 

ASF GitHub Bot commented on ARIA-262:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/141#discussion_r120014104
  
    --- Diff: aria/orchestrator/decorators.py ---
    @@ -48,7 +48,7 @@ def _wrapper(ctx, **workflow_parameters):
     
             workflow_parameters.setdefault('ctx', ctx)
             workflow_parameters.setdefault('graph', 
task_graph.TaskGraph(workflow_name))
    -        validate_function_arguments(func, workflow_parameters)
    +        validate_function_arguments(func, **workflow_parameters)
    --- End diff --
    
    add instrumentation to workflow too?


> Inconsistent node attributes behavior
> -------------------------------------
>
>                 Key: ARIA-262
>                 URL: https://issues.apache.org/jira/browse/ARIA-262
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Maxim Orlov
>            Assignee: Maxim Orlov
>
> ARIA provides sugaring for node attributes. However this sugaring is somewhat 
> limited, as it sugars ctx accessed attributes. e.g. Under 
> NodeOperationContext {{ctx.node.attributes}} has a dict-like behavior, where 
> the value is another object with a dict-like behavior. This is provided by 
> the sugaring. 
> However {{ctx.node.relationships[0].target_node.attributes}} provides a dict 
> where the value is of type Parameter, accessing the value of this Parameter 
> requires {{param.value}} This creates inconsistency with regards to access to 
> attributes.
> There are several possible solutions:
> 1. Enable sugaring on the model level. this will effectively make the 
> creation of Parameter implicit, but this will be possible throughout the 
> entire code (not only under context).
> 2. Enable sugaring by tapping to sqla events and altering the return values. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to