[
https://issues.apache.org/jira/browse/ARIA-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372468#comment-16372468
]
ASF GitHub Bot commented on ARIA-437:
-------------------------------------
VenkatesanVenugopal closed pull request #223: ARIA-437: ARIA does not support
some of the combinations for requirement declarations (at the node type) and
some for requirement assignments (at the node template)
URL: https://github.com/apache/incubator-ariatosca/pull/223
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/aria/orchestrator/topology/instance_handler.py
b/aria/orchestrator/topology/instance_handler.py
index fad00b9c..a1d61fd8 100644
--- a/aria/orchestrator/topology/instance_handler.py
+++ b/aria/orchestrator/topology/instance_handler.py
@@ -294,8 +294,9 @@ def _find_target(self, requirement_template):
return target_node_template, target_node_capability
- # Find the first node which has a capability of the required type
- elif requirement_template.target_capability_type is not None:
+ # Find the first node which has a capability of the required type or
name
+ elif requirement_template.target_capability_type is not None or \
+ requirement_template.target_capability_name is not None:
for target_node_template in \
self._model.node_template.service_template.node_templates.itervalues():
target_node_capability = \
@@ -323,6 +324,10 @@ def _satisfies_requirement(
capability_template.type.name) is None):
return False
+ if requirement_template.target_capability_name is not None:
+ if not requirement_template.target_capability_name ==
capability_template.name:
+ return False
+
# Are we in valid_source_node_types?
if capability_template.valid_source_node_types:
for valid_source_node_type in
capability_template.valid_source_node_types:
diff --git a/extensions/aria_extension_tosca/simple_v1_0/assignments.py
b/extensions/aria_extension_tosca/simple_v1_0/assignments.py
index 62484839..c47a5e9d 100644
--- a/extensions/aria_extension_tosca/simple_v1_0/assignments.py
+++ b/extensions/aria_extension_tosca/simple_v1_0/assignments.py
@@ -324,9 +324,19 @@ def _get_capability(self, context):
capabilities = node._get_capabilities(context)
if capability in capabilities:
return capabilities[capability], 'capability_assignment'
- capability_type = get_type_by_name(context, capability,
'capability_types')
- if capability_type is not None:
- return capability_type, 'capability_type'
+ capability_type = get_type_by_name(context, capability,
'capability_types')
+ if capability_type is not None:
+ return capability_type, 'capability_type'
+ else:
+ capability_type = get_type_by_name(context, capability,
'capability_types')
+ if capability_type is not None:
+ return capability_type, 'capability_type'
+
+ for the_node_template in
context.presentation.presenter.service_template.\
+
topology_template.node_templates.iteritems():
+ the_capabilities =
the_node_template[1]._get_capabilities(context)
+ if capability in the_capabilities:
+ return the_capabilities[capability],
'capability_assignment'
return None, None
diff --git
a/extensions/aria_extension_tosca/simple_v1_0/presentation/field_validators.py
b/extensions/aria_extension_tosca/simple_v1_0/presentation/field_validators.py
index 2ff51438..c79a695a 100644
---
a/extensions/aria_extension_tosca/simple_v1_0/presentation/field_validators.py
+++
b/extensions/aria_extension_tosca/simple_v1_0/presentation/field_validators.py
@@ -347,22 +347,108 @@ def node_template_or_type_validator(field, presentation,
context):
value = getattr(presentation, field.name)
if value is not None:
- node_templates = \
- context.presentation.get('service_template', 'topology_template',
'node_templates') \
- or {}
- if (value not in node_templates) and \
- (get_type_by_name(context, value, 'node_types') is None):
- report_issue_for_unknown_type(context, presentation, 'node
template or node type',
- field.name)
+ node, node_variant = presentation._get_node(context)
+ if node_variant == 'node_template':
+ node_template_validator(field, presentation, context, value, node)
+ elif node_variant == 'node_type':
+ node_type_validator(field, presentation, context, value, node)
+ else:
+ context.validation.report(
+ '"%s" refers to a node type or node template that does not
match the capability '
+ 'requirement in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_FIELDS)
+
+def node_template_validator(field, presentation, context, node_value,
node_obj):
+ """
+ Makes sure that the field refers to a node template.
+ """
+ the_node_templates = context.presentation.get('service_template',
'topology_template',\
+ 'node_templates') or
{}
+ the_parent_capability_type_name = _get_requirement_in_type(context,
presentation).\
+ capability
+ the_parent_node_type_name = _get_requirement_in_type(context,
presentation).node
+ the_nodetype_obj = node_obj._get_type(context)
+
+ if node_value not in the_node_templates:
+ context.validation.report(
+ '"%s" refers to an unknown node template in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_FIELDS)
+ return
+ if the_parent_node_type_name:
+ if not _is_parent(context, the_nodetype_obj,
the_parent_node_type_name, 'node_types'):
+ context.validation.report(
+ '"%s" refers to an unknown/inappropriate node type in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),\
+ level=Issue.BETWEEN_FIELDS)
+ return
+
+ if the_nodetype_obj._get_capabilities(context):
+ the_capabilities = the_nodetype_obj._get_capabilities(context)
+ for the_capability in the_capabilities.iteritems():
+ if _is_parent(context, the_capability[1]._get_type(context),\
+ the_parent_capability_type_name, 'capability_types'):
+ return
+ context.validation.report(
+ '"%s" refers to a node template that does not match the capability
requirement in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_FIELDS)
+ return
+
+def node_type_validator(field, presentation, context, node_value, node_obj):
+ """
+ Makes sure that the field refers to a node type.
+ """
+ the_child_nodetypes = []
+ the_parent_capability_type_name = _get_requirement_in_type(context,
presentation).\
+ capability
+ the_parent_node_type_name = _get_requirement_in_type(context,
presentation).node
+
+ node_type = get_type_by_name(context, node_value, 'node_types')
+ if node_type is None:
+ context.validation.report(
+ '"%s" refers to an unknown node type in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),\
+ level=Issue.BETWEEN_FIELDS)
+ return
+
+ if the_parent_node_type_name:
+ if not _is_parent(context, node_obj, the_parent_node_type_name,
'node_types'):
+ context.validation.report(
+ '"%s" refers to an unknown/inappropriate node type in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),\
+ level=Issue.BETWEEN_FIELDS)
+ return
+
+ for the_node_type in
context.presentation.presenter.service_template.node_types.\
+ iteritems():
+ if the_node_type[1]._get_capabilities(context):
+ the_capabilities = the_node_type[1]._get_capabilities(context)
+ for the_capability in the_capabilities.iteritems():
+ if _is_parent(context, the_capability[1]._get_type(context),\
+ the_parent_capability_type_name,
'capability_types'):
+ the_child_nodetypes.append(the_node_type)
+
+ for the_child_node_type in the_child_nodetypes:
+ if _is_parent(context, the_child_node_type[1], node_obj._name,
'node_types'):
+ return
+
+ context.validation.report(
+ '"%s" refers to a node type that does not match the capability
requirement in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_FIELDS)
+ return
def capability_definition_or_type_validator(field, presentation, context):
"""
Makes sure refers to either a capability assignment name in the node
template referred to by the
``node`` field or a general capability type.
- If the value refers to a capability type, make sure the ``node`` field was
not assigned.
-
Used with the :func:`field_validator` decorator for the ``capability``
field in
:class:`RequirementAssignment`.
"""
@@ -372,31 +458,140 @@ def capability_definition_or_type_validator(field,
presentation, context):
value = getattr(presentation, field.name)
if value is not None:
node, node_variant = presentation._get_node(context)
- if node_variant == 'node_template':
- capabilities = node._get_capabilities(context)
- if value in capabilities:
- return
+ capability_variant = presentation._get_capability(context)[1]
- if get_type_by_name(context, value, 'capability_types') is not None:
- if node is not None:
- context.validation.report(
- u'"{0}" refers to a capability type even though "node" has
a value in "{1}"'
- .format(presentation._name,
presentation._container._fullname),
- locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_FIELDS)
- return
-
- if node_variant == 'node_template':
- context.validation.report(
- u'requirement "{0}" refers to an unknown capability definition
name or capability'
- u' type in "{1}": {2}'
- .format(presentation._name, presentation._container._fullname,
safe_repr(value)),
- locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_TYPES)
+ if capability_variant == 'capability_assignment':
+ capability_definition_validator(field, presentation, context,
value, node, node_variant)
+ elif capability_variant == 'capability_type':
+ capability_type_validator(field, presentation, context, value,
node, node_variant)
else:
context.validation.report(
- u'requirement "{0}" refers to an unknown capability type in
"{1}": {2}'
- .format(presentation._name, presentation._container._fullname,
safe_repr(value)),
+ 'requirement "%s" refers to an unknown capability definition
name or '\
+ 'type in "%s": %s'
+ % (presentation._name, presentation._container._fullname,
safe_repr(value)),
locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_TYPES)
+def capability_definition_validator(field, presentation, context,
capability_value, node_obj,
+ node_variant):
+ """
+ Makes sure if the capability name in the node template refers to a general
capability definition
+ """
+ the_parent_capability_type_name = _get_requirement_in_type(context,
presentation).\
+ capability
+ the_parent_node_type_name = _get_requirement_in_type(context,
presentation).node
+
+ if node_obj:
+ _is_capability_in_node(context, node_variant, node_obj, presentation,
field,
+ capability_value)
+
+ if the_parent_node_type_name:
+ the_nodetype_obj = get_type_by_name(context,
the_parent_node_type_name,\
+ 'node_types')
+ _is_capability_in_node(context, 'node_type', the_nodetype_obj,
presentation,\
+ field, capability_value)
+
+ for the_node_type in
context.presentation.presenter.service_template.node_types.\
+ iteritems():
+ if the_node_type[1]._get_capabilities(context):
+ the_capabilities = the_node_type[1]._get_capabilities(context)
+ for the_capability in the_capabilities.iteritems():
+ if the_capability[1]._name == capability_value:
+ the_capability_type_name = the_capability[1].type
+
+ the_capability_type_obj = get_type_by_name(context,
the_capability_type_name,\
+ 'capability_types')
+ if _is_parent(context, the_capability_type_obj,
the_parent_capability_type_name,
+ 'capability_types'):
+ return
+
+def capability_type_validator(field, presentation, context, capability_value,
node_obj,
+ node_variant):
+ """
+ Makes sure if the capability type in the node template refers to a general
capability type
+ """
+ the_parent_capability_type_name = _get_requirement_in_type(context,
presentation).\
+ capability
+ the_parent_node_type_name = _get_requirement_in_type(context,
presentation).node
+ the_capability_type_obj = get_type_by_name(context, capability_value,
'capability_types')
+
+ if node_obj:
+ _is_capability_in_node(context, node_variant, node_obj, presentation,
field,
+ capability_value)
+
+ if the_parent_node_type_name:
+ the_nodetype_obj = get_type_by_name(context,
the_parent_node_type_name,\
+ 'node_types')
+ _is_capability_in_node(context, 'node_type', the_nodetype_obj,
presentation,\
+ field, capability_value)
+
+ if the_capability_type_obj is not None and \
+ _is_parent(context, the_capability_type_obj,
the_parent_capability_type_name,
+ 'capability_types'):
+
+ return
+
+def _get_requirement_in_type(context, presentation):
+ the_nodetype_obj = presentation._container._get_type(context)
+ the_requirements_obj = the_nodetype_obj._get_requirements(context)
+ the_requirement_obj = None
+ for the_requirement in the_requirements_obj:
+ if the_requirement[0] == presentation._name:
+ the_requirement_obj = the_requirement[1]
+ return the_requirement_obj
+
+def _is_capability_in_node(context, node_variant, node, presentation, field,
value):
+ if node_variant == 'node_template':
+ the_nodetype_obj = node._get_type(context)
+ if the_nodetype_obj._get_capabilities(context):
+ the_capabilities = the_nodetype_obj._get_capabilities(context)
+ for the_capability in the_capabilities.iteritems():
+ if the_capability[1]._name == value or \
+ _is_parent(context, the_capability[1]._get_type(context),
value,
+ 'capability_types'):
+ return
+
+ context.validation.report(
+ '"%s" refers to a node template that does not match the
capability requirement '\
+ 'in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_FIELDS)
+ return
+
+
+ if node_variant == 'node_type':
+ the_child_nodetypes = []
+ if get_type_by_name(context, node._name, 'node_types') is None:
+ context.validation.report(
+ '"%s" refers to an unknown/inappropriate node type in "%s"'
+ % (presentation._name, presentation._container._fullname),
+ locator=presentation._get_child_locator(field.name),
level=Issue.BETWEEN_FIELDS)
+ return
+
+ for the_node_type in
context.presentation.presenter.service_template.node_types.iteritems():
+ if the_node_type[1]._get_capabilities(context):
+ the_capabilities = the_node_type[1]._get_capabilities(context)
+ for the_capability in the_capabilities.iteritems():
+ if the_capability[1].type == value or
the_capability[1]._name == value:
+ the_child_nodetypes.append(the_node_type)
+
+ for the_node_type in the_child_nodetypes:
+ if _is_parent(context, the_node_type[1], node._name, 'node_types'):
+ return
+
+def _is_parent(context, type_obj, parent_type_name, parent_type):
+ parent_type_name = convert_name_to_full_type_name(context,
parent_type_name,
+
context.presentation.get('service_template',
+
parent_type))
+ if type_obj._name == parent_type_name:
+ return True
+ the_parent = type_obj._get_parent(context)
+ if the_parent is not None:
+ if the_parent._name == parent_type_name:
+ return True
+ found = _is_parent(context, the_parent, parent_type_name, parent_type)
+ return found
+ else:
+ return False
def node_filter_validator(field, presentation, context):
"""
diff --git
a/tests/extensions/aria_extension_tosca/simple_v1_0/templates/node_template/test_node_template_requirements.py
b/tests/extensions/aria_extension_tosca/simple_v1_0/templates/node_template/test_node_template_requirements.py
index fdf6f16b..4b9d722c 100644
---
a/tests/extensions/aria_extension_tosca/simple_v1_0/templates/node_template/test_node_template_requirements.py
+++
b/tests/extensions/aria_extension_tosca/simple_v1_0/templates/node_template/test_node_template_requirements.py
@@ -200,7 +200,9 @@ def
test_node_template_requirement_capability_type_short_form(parser):
my_node:
type: MyType
requirements:
- - my_requirement: MyType
+ - my_requirement: my_node1
+ my_node1:
+ type: MyType
""").assert_success()
diff --git a/tests/topology/service_templates.py
b/tests/topology/service_templates.py
index 60d5ad0b..8b0dd38c 100644
--- a/tests/topology/service_templates.py
+++ b/tests/topology/service_templates.py
@@ -33,7 +33,7 @@ def consume_literal(literal, consumer_class_name='instance',
cache=True, no_issu
return context, dumper
-def consume_use_case(use_case_name, consumer_class_name='instance',
cache=True):
+def consume_use_case(use_case_name, consumer_class_name='instance',
cache=True, no_issues=True):
cachedmethod.ENABLED = cache
uri = get_example_uri('tosca-simple-1.0', 'use-cases', use_case_name,
'{0}.yaml'.format(use_case_name))
@@ -44,7 +44,12 @@ def consume_use_case(use_case_name,
consumer_class_name='instance', cache=True):
consumer, dumper = create_consumer(context, consumer_class_name)
consumer.consume()
context.validation.dump_issues()
- assert not context.validation.has_issues
+
+ if no_issues:
+ assert not context.validation.has_issues
+ else:
+ assert context.validation.has_issues
+
return context, dumper
diff --git a/tests/topology/test_end2end.py b/tests/topology/test_end2end.py
index a583db55..5428bdb5 100644
--- a/tests/topology/test_end2end.py
+++ b/tests/topology/test_end2end.py
@@ -83,7 +83,7 @@ def test_use_case_multi_tier_1():
def test_use_case_container_1():
- consume_use_case('container-1', 'template')
+ consume_use_case('container-1', 'template', no_issues=False)
# NodeCellar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ARIA does not support some of the combinations for requirement declarations
> (at the node type) and some for requirement assignments (at the node
> template).
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ARIA-437
> URL: https://issues.apache.org/jira/browse/ARIA-437
> Project: AriaTosca
> Issue Type: Bug
> Affects Versions: 0.1.1
> Reporter: D Jayachandran
> Priority: Minor
>
> As per TOSCA specification is required for the below combinations to be
> working for Requirement declaration.
> 1) Node type definition with capability type
> 2) Node type definition with capability type and node type
> With any of the above requirement declaration it should be possible to have
> the below combinations of requirement assignment in node templates
> * capability type alone
> * capability name alone
> * node type alone
> * node name alone
> * capability name and node name
> * capability name and node type
> * capability type and node type
> * capability type and node type
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
