[
https://issues.apache.org/jira/browse/ARROW-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558878#comment-15558878
]
Wes McKinney commented on ARROW-112:
------------------------------------
I'd prefer to leave the enums as is and only fix the constants (macro-like
naming is OK by Google:
https://google.github.io/styleguide/cppguide.html#Enumerator_Names -- FWIW this
is also the convention used by Kudu
https://github.com/apache/kudu/blob/master/src/kudu/common/common.proto#L33 and
Impala
https://github.com/cloudera/Impala/blob/cdh5-trunk/be/src/runtime/types.h#L37,
which are both reasonably conforming to the Google guide)
> [C++] Style fix for constants/enums
> ------------------------------------
>
> Key: ARROW-112
> URL: https://issues.apache.org/jira/browse/ARROW-112
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Micah Kornfield
>
> We should prefer kValue to VALUE according to google style guide. We should
> do one round of cleanup here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
