Wes McKinney created ARROW-437:
----------------------------------
Summary: [C++] clang compiler warnings from overridden virtual
functions
Key: ARROW-437
URL: https://issues.apache.org/jira/browse/ARROW-437
Project: Apache Arrow
Issue Type: Bug
Components: C++
Reporter: Wes McKinney
{code}
n file included from /home/wesm/code/arrow/cpp/src/arrow/array.cc:18:
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:176:13: note: in instantiation of
template class 'arrow::NumericArray<arrow::FloatType>' requested here
inline bool NumericArray<FloatType>::ApproxEquals(
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:212:13: note: in instantiation of
template class 'arrow::NumericArray<arrow::DoubleType>' requested here
inline bool NumericArray<DoubleType>::ApproxEquals(
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:459:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::Int8Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<Int8Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:460:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::UInt8Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<UInt8Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:461:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::Int16Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<Int16Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:462:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::UInt16Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<UInt16Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:463:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::Int32Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<Int32Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:464:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::UInt32Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<UInt32Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:465:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::Int64Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<Int64Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:466:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::UInt64Type>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<UInt64Type>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:467:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::HalfFloatType>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<HalfFloatType>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:470:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::TimestampType>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<TimestampType>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:471:62: note: in instantiation of
template class 'arrow::NumericArray<arrow::DateType>' requested here
extern template class __attribute__((visibility("default")))
NumericArray<DateType>;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:150:8: error: 'ApproxEquals'
overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return
Equals(arr); }
^
/home/wesm/code/arrow/cpp/src/arrow/array.cc:88:25: note: in instantiation of
template class 'arrow::NumericArray<arrow::IntervalType>' requested here
return visitor->Visit(*this);
^
/home/wesm/code/arrow/cpp/src/arrow/array.h:68:16: note: overridden virtual
function is here
virtual bool ApproxEquals(const std::shared_ptr<Array>& arr) const;
^
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
