[
https://issues.apache.org/jira/browse/ARROW-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wes McKinney resolved ARROW-518.
--------------------------------
Resolution: Won't Fix
Assignee: Wes McKinney
Based on the performance analysis in
https://issues.cloudera.org/browse/IMPALA-1916, the inline constructor will be
faster than a constexpr that uses a global variable due to invoking the copy
constructor. Leaving OK as is makes Arrow consistent with the current code in
Impala and Kudu
Here also is the implementation of OK() in TensorFlow:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/lib/core/status.h#L44
> C++: Make Status::OK method constexpr
> -------------------------------------
>
> Key: ARROW-518
> URL: https://issues.apache.org/jira/browse/ARROW-518
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Uwe L. Korn
> Assignee: Wes McKinney
> Labels: beginner, newbie
>
> We call this method very often and probably have a small overhead as it isn't
> {{constexpr}}. We also cannot simply declare it {{constexpr}} as
> {{arrow::Status}} is not a literal type yet.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
