[ 
https://issues.apache.org/jira/browse/ARROW-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wes McKinney reassigned ARROW-758:
----------------------------------

    Assignee: Wes McKinney

> [C++] Fix compiler warnings on MSVC x64
> ---------------------------------------
>
>                 Key: ARROW-758
>                 URL: https://issues.apache.org/jira/browse/ARROW-758
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>             Fix For: 0.3.0
>
>
> I've fixed some in ARROW-657, but there are more:
> {code}
>   C:\Program Files (x86)\Microsoft Visual 
> Studio\Shared\14.0\VC\include\numeric(20): warning C4244: '=': conversion 
> from 'int64_t' to 'int', possible loss of data [C:\Users 
> \wesm\code\arrow\cpp\build\arrow_objlib.vcxproj]
> "C:\Users\wesm\code\arrow\cpp\build\ALL_BUILD.vcxproj" (default target) (1) ->
> "C:\Users\wesm\code\arrow\cpp\build\src\arrow\array-test.vcxproj" (default 
> target) (9) ->
>   C:\Users\wesm\code\arrow\cpp\src\arrow\array-test.cc(337): warning C4800: 
> 'unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wesm\co de\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\array-test.cc(1382): warning C4800: 
> 'const unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\ wesm\code\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\array-test.cc(499): warning C4800: 
> 'unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wesm\co de\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\array-test.cc(504): warning C4800: 
> 'unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wesm\co de\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\array-test.cc(521): warning C4800: 
> 'unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wesm\co de\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\array-test.cc(525): warning C4800: 
> 'unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wesm\co de\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\array-test.cc(398): warning C4800: 
> 'unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wesm\co de\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   
> C:\Users\wesm\code\arrow\cpp\build\googletest_ep-prefix\src\googletest_ep\include\gtest/gtest.h(1448):
>  warning C4805: '==': unsafe mix of type 'const unsigned char' and t ype 
> 'const bool' in operation 
> [C:\Users\wesm\code\arrow\cpp\build\src\arrow\array-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow/test-util.h(256): warning C4800: 
> 'const unsigned char': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wes m\code\arrow\cpp\build\src\arrow\array-test.vcxproj]
> "C:\Users\wesm\code\arrow\cpp\build\ALL_BUILD.vcxproj" (default target) (1) ->
> "C:\Users\wesm\code\arrow\cpp\build\src\arrow\ipc\arrow_ipc_objlib.vcxproj" 
> (default target) (14) ->
>   C:\Users\wesm\code\arrow\cpp\src\arrow\ipc\json-internal.cc(1092): warning 
> C4800: 'int': forcing value to bool 'true' or 'false' (performance warning) 
> [C:\Users\wesm\code \arrow\cpp\build\src\arrow\ipc\arrow_ipc_objlib.vcxproj]
> "C:\Users\wesm\code\arrow\cpp\build\ALL_BUILD.vcxproj" (default target) (1) ->
> "C:\Users\wesm\code\arrow\cpp\build\src\arrow\io\io-hdfs-test.vcxproj" 
> (default target) (26) ->
>   C:\Users\wesm\code\arrow\cpp\src\arrow\io\io-hdfs-test.cc(110): warning 
> C4800: 'const char *': forcing value to bool 'true' or 'false' (performance 
> warning) [C:\Users\wes 
> m\code\arrow\cpp\build\src\arrow\io\io-hdfs-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\io\io-hdfs-test.cc(106): warning 
> C4996: 'getenv': This function or variable may be unsafe. Consider using 
> _dupenv_s instead. To dis able deprecation, use _CRT_SECURE_NO_WARNINGS. See 
> online help for details. 
> [C:\Users\wesm\code\arrow\cpp\build\src\arrow\io\io-hdfs-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\io\io-hdfs-test.cc(107): warning 
> C4996: 'getenv': This function or variable may be unsafe. Consider using 
> _dupenv_s instead. To dis able deprecation, use _CRT_SECURE_NO_WARNINGS. See 
> online help for details. 
> [C:\Users\wesm\code\arrow\cpp\build\src\arrow\io\io-hdfs-test.vcxproj]
>   C:\Users\wesm\code\arrow\cpp\src\arrow\io\io-hdfs-test.cc(108): warning 
> C4996: 'getenv': This function or variable may be unsafe. Consider using 
> _dupenv_s instead. To dis able deprecation, use _CRT_SECURE_NO_WARNINGS. See 
> online help for details. 
> [C:\Users\wesm\code\arrow\cpp\build\src\arrow\io\io-hdfs-test.vcxproj]
>     15 Warning(s)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to