[ https://issues.apache.org/jira/browse/ARROW-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney resolved ARROW-782. -------------------------------- Resolution: Fixed Issue resolved by pull request 520 [https://github.com/apache/arrow/pull/520] > [C++] Change struct to class for objects that meet the criteria in the Google > style guide > ----------------------------------------------------------------------------------------- > > Key: ARROW-782 > URL: https://issues.apache.org/jira/browse/ARROW-782 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ > Reporter: Wes McKinney > Assignee: Wes McKinney > Fix For: 0.3.0 > > > See https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes. I > have suspected that the types in {{type.h}} should be classes, but this > suggests it pretty strongly. It would be better to address this sooner rather > than later. > We should also make the member access functions instead of bare attributes, > e.g. {{type->id()}} instead of {{type->type}} -- This message was sent by Atlassian JIRA (v6.3.15#6346)