[
https://issues.apache.org/jira/browse/ARROW-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059300#comment-16059300
]
Toby Shaw commented on ARROW-1134:
----------------------------------
[~xhochy] Somewhat tangential, but I'm not sure where else to post this.
You mention all public Arrow headers can be included via #include
<arrow/api.h>. Unless I'm mistaken, this doesn't seem to include
arrow/io/file.h, which is included in parquet-cpp, see:
[https://github.com/apache/parquet-cpp/blob/master/src/parquet/file/reader.cc#L26].
Should parquet depend on non-public Arrow headers?
> Allow C++/CLI projects to build with Arrow
> --------------------------------------------
>
> Key: ARROW-1134
> URL: https://issues.apache.org/jira/browse/ARROW-1134
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Toby Shaw
> Priority: Minor
>
> Currently, the inclusion of <mutex> in some of Arrow's C++ headers prevents
> C++/CLI code from building against it.
> From a C++/CLI project:
> #include <arrow/io/file.h>
> ...
> "#error directive: <mutex> is not supported when compiling with /clr or
> /clr:pure."
> This could be patched by optionally relying on Boost's mutex/lock_guard
> instead of std, or not exposing the #include <mutex> publically.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
