[
https://issues.apache.org/jira/browse/ARROW-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109858#comment-16109858
]
SIDDHARTH TEOTIA edited comment on ARROW-886 at 8/1/17 9:48 PM:
----------------------------------------------------------------
[~elahrvivaz],
Just picking up the conversation. Are you fine with the following changes?
(1) Make realloc() back to being an internal method
(2) Don't do explicit re-allocation of the offsetVector() from the realloc()
function in VariableLengthVectors.java. If we call setSafe() on variable length
vector, it will internally invoke setSafe() on the corresponding offsetVector
and the latter function can decide whether to reallocate the offsetVector or
not.
(3) Finally, as Steven suggested, we can add a new method to the ValueVector
interface that can allow growing the offsetVector() independent of calling
realloc() and growing the variable length data buffer.
Thanks,
Siddharth
was (Author: siddteotia):
[~elahrvivaz]
Just picking up the conversation. Are you fine with the following changes?
(1) Make realloc() back to being an internal method
(2) Don't do explicit re-allocation of the offsetVector() from the realloc()
function in VariableLengthVectors.java. If we call setSafe() on variable length
vector, it will internally invoke setSafe() on the corresponding offsetVector
and the latter function can decide whether to reallocate the offsetVector or
not.
(3) Finally, as Steven suggested, we can add a new method to the ValueVector
interface that can allow growing the offsetVector() independent of calling
realloc() and growing the variable length data buffer.
Thanks,
Siddharth
> VariableLengthVectors don't reAlloc offsets
> -------------------------------------------
>
> Key: ARROW-886
> URL: https://issues.apache.org/jira/browse/ARROW-886
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Affects Versions: 0.3.0
> Reporter: Emilio Lahr-Vivaz
> Assignee: Emilio Lahr-Vivaz
> Fix For: 0.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
