[ 
https://issues.apache.org/jira/browse/ARROW-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117627#comment-16117627
 ] 

Wes McKinney commented on ARROW-1335:
-------------------------------------

PR: https://github.com/apache/arrow/pull/949. I think it's best to make the 
function consistent with the other {{raw_values}} functions

> [C++] PrimitiveArray::raw_values has inconsistent semantics re: offsets 
> compared with subclasses
> ------------------------------------------------------------------------------------------------
>
>                 Key: ARROW-1335
>                 URL: https://issues.apache.org/jira/browse/ARROW-1335
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>             Fix For: 0.6.0
>
>
> {{NumericArray<T>::raw_values}} accounts for offset, while 
> {{PrimitiveArray::raw_values}} does not. This seems likely to lead to 
> shooting one's self in the foot. It may be better to remove 
> {{PrimitiveArray::raw_values}} altogether



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to