[ 
https://issues.apache.org/jira/browse/ARROW-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138419#comment-16138419
 ] 

Wes McKinney commented on ARROW-1401:
-------------------------------------

In release builds we could print only the file and line number which might 
help. We should look at the change in code size and performance (e.g. the 
microbenchmarks in ipc-read-write-benchmark would be a good place to look); the 
effects of larger code size are insidious because of the impact on the 
instruction cache.

> [C++] Add extra debugging context to failures in RETURN_NOT_OK in debug builds
> ------------------------------------------------------------------------------
>
>                 Key: ARROW-1401
>                 URL: https://issues.apache.org/jira/browse/ARROW-1401
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>             Fix For: 0.7.0
>
>
> This should show
> * the statement that failed
> * the file and line number
> I implemented this for CUDA failures in 
> https://github.com/apache/arrow/pull/985 and I really like it. If we add glog 
> to our toolchain we may be able to get full stack traces on failures. 
> It would probably increase code size to much in release builds, so it should 
> be a DEBUG only feature. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to