[
https://issues.apache.org/jira/browse/ARROW-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johan Peltenburg updated ARROW-1543:
------------------------------------
Description:
In the row_wise_conversion code example we find:
{code}
std::shared_ptr<DoubleBuilder> components_values_builder =
std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
arrow::ListBuilder components_builder(arrow::default_memory_pool(),
components_values_builder);
{code}
This generates some compile time errors since the second argument of the
ListBuilder constructor expects a unique pointer.
However, I guess the example shows the correct case, where we want to still be
able to use the DoubleBuilder after constructing the ListBuilder, so I probably
shouldn't std::move it to the constructor as a unique_ptr.
I'm not sure how to fix this as I don't know which functionality is desired.
was:
In the row_wise_conversion code example we find:
{code:c++}
std::shared_ptr<DoubleBuilder> components_values_builder =
std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
arrow::ListBuilder components_builder(arrow::default_memory_pool(),
components_values_builder);
{code}
This generates some compile time errors since the second argument of the
ListBuilder constructor expects a unique pointer.
However, I guess the example shows the correct case, where we want to still be
able to use the DoubleBuilder after constructing the ListBuilder, so I probably
shouldn't std::move it to the constructor as a unique_ptr.
I'm not sure how to fix this as I don't know which functionality is desired.
> row_wise_conversion example doesn't correspond to ListBuilder constructor
> arguments
> -----------------------------------------------------------------------------------
>
> Key: ARROW-1543
> URL: https://issues.apache.org/jira/browse/ARROW-1543
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.7.0
> Reporter: Johan Peltenburg
> Priority: Trivial
>
> In the row_wise_conversion code example we find:
> {code}
> std::shared_ptr<DoubleBuilder> components_values_builder =
> std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
> arrow::ListBuilder components_builder(arrow::default_memory_pool(),
> components_values_builder);
> {code}
> This generates some compile time errors since the second argument of the
> ListBuilder constructor expects a unique pointer.
> However, I guess the example shows the correct case, where we want to still
> be able to use the DoubleBuilder after constructing the ListBuilder, so I
> probably shouldn't std::move it to the constructor as a unique_ptr.
> I'm not sure how to fix this as I don't know which functionality is desired.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
