[
https://issues.apache.org/jira/browse/ARROW-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169400#comment-16169400
]
ASF GitHub Bot commented on ARROW-1534:
---------------------------------------
GitHub user cpcloud opened a pull request:
https://github.com/apache/arrow/pull/1108
WIP: ARROW-1534: [C++] Decimal128::ToBytes and uint8_t* constructor should
return/assume big-endian byte order
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cpcloud/arrow ARROW-1534
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1108
----
commit dcc55567b32767a7bc9a27a75c446822a797540b
Author: Phillip Cloud <[email protected]>
Date: 2017-09-12T23:29:42Z
[C++] Decimal128::ToBytes and uint8_t* constructor should return/assume
big-endian byte order
commit 1675f1069da908a9edc4e14d054624484406dbdd
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T18:42:51Z
Pass in in array.cc
commit 27f6d39d8c1108701a135070e40fd2531fc387be
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T18:43:11Z
We can only append with a given length now
commit 5a90a17aa43e0abdbea462b3f3ceab38f96fbd77
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T18:43:52Z
Compute byte width as minimum necessary bytes to represent
commit a54458e46ea624d3908561cd9f9afbe19624904d
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T18:44:24Z
Fix up arrow to pandas conversion
commit 8381f543ea102a93c7c647e44805a0e59e2ad882
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:25:23Z
Clean up pretty print test
commit 3e77b5c8c82fb309695cff9ed9f37f9729e65097
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:25:34Z
Fix type test
commit e541d7abfd8c8ff4891fb09e327f24a540123017
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:34:40Z
Format correctly
commit f94c168925a0bf654615b8de24a782c0a91c6c9e
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:35:26Z
More docs and generalize integer constructor using SFINAE
commit 8869948ee1959d54c152f7c9e79f4a7a80286486
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:42:22Z
Fix array-test to make byte_width dynamic
commit 89a3fca87c6a3815f09c03d02a07ba9954a48253
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:42:32Z
Only append the necessary bytes
commit 00d8285867680e7951fdb3087420b2ad8d29b1b8
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:42:40Z
Add bitutil constant
commit 7d1f3099633440cccef37740da821ee866178768
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:42:49Z
Fixup decimal test
commit 8445aec98badc3866c129cb5dd61ba825d42a165
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:48:18Z
Cleanups
commit 924fd237cb1a164da52eb0f04c1f6922b3fcd7f0
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:48:41Z
Implement bytes constructor with required length
commit 72bb078e3a5e8670d574d74c6cb96282b880ef42
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:49:06Z
Add ostream for iostream pretty printing/debugging
commit 347420169645592f010e7f61a146edd4c78d9089
Author: Phillip Cloud <[email protected]>
Date: 2017-09-17T19:50:45Z
Pass by pointer instead of reference
----
> [C++] Decimal128::ToBytes and uint8_t* constructor should return/assume
> big-endian byte order
> ---------------------------------------------------------------------------------------------
>
> Key: ARROW-1534
> URL: https://issues.apache.org/jira/browse/ARROW-1534
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.6.0
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
