[ 
https://issues.apache.org/jira/browse/ARROW-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174007#comment-16174007
 ] 

ASF GitHub Bot commented on ARROW-1347:
---------------------------------------

GitHub user BryanCutler opened a pull request:

    https://github.com/apache/arrow/pull/1119

    ARROW-1347: [JAVA] Return consistent child field name for List Vectors

    This makes the child fields of ListVector have consistent names of 
`ListVector.DATA_VECTOR_NAME`. Previously, an empty ListVector would have a 
child name of `ZeroVector.name` which is "[DEFAULT]".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BryanCutler/arrow 
java-ListVector-child-name-ARROW-1347

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/arrow/pull/1119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1119
    
----
commit 2923a453ef005278db834e85d6fa084dbc3453a3
Author: Steven Phillips <ste...@dremio.com>
Date:   2017-08-10T22:15:28Z

    ARROW-1347: [JAVA] return consistent child field name for List vectors

commit c240378b3122d95351ad97db78bfb45d34097d61
Author: Bryan Cutler <cutl...@gmail.com>
Date:   2017-09-20T23:25:28Z

    changed to use instanceof and added test

----


> [JAVA] List null type should use consistent name for inner field
> ----------------------------------------------------------------
>
>                 Key: ARROW-1347
>                 URL: https://issues.apache.org/jira/browse/ARROW-1347
>             Project: Apache Arrow
>          Issue Type: Bug
>            Reporter: Steven Phillips
>            Assignee: Steven Phillips
>              Labels: pull-request-available
>
> The child field for List type has the field name "$data$" in most cases. In 
> the case that there is not a known type for the List, currently the 
> getField() method will return a subfield with name "DEFAULT". We should make 
> this consistent with the rest of the cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to