[
https://issues.apache.org/jira/browse/ARROW-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181464#comment-16181464
]
ASF GitHub Bot commented on ARROW-1613:
---------------------------------------
GitHub user BryanCutler opened a pull request:
https://github.com/apache/arrow/pull/1138
ARROW-1613: [Java] Removed closing of ReadChannel from ArrowReader.close()
This change removes the closing of the input `ReadChannel` from
`ArrowReader.close()` so it can be left up to the creator of the channel.
`ArrowReader.close()` will still release resources from `VectorSchemaRoot` and
any Dictionary vectors read. Also updated usage in tests to close input
channels correctly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/arrow
java-ArrowRead-not-close-input-ARROW-1613
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1138
----
commit 7d95df94d99fe629f0f331a19fb315af7d7bb1f8
Author: Bryan Cutler <[email protected]>
Date: 2017-09-26T19:32:02Z
Removed closing of ReadChannel from ArrowReader.close() and updated usage
in tests to close things correctly
----
> [Java] ArrowReader should not close the input ReadChannel
> ---------------------------------------------------------
>
> Key: ARROW-1613
> URL: https://issues.apache.org/jira/browse/ARROW-1613
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
>
> Currently, {{ArrowReader.close()}} will close resources (VectorSchemaRoot and
> Dictionary Vectors) and also close the input ReadChannel, or InputStream for
> ArrowStreamReader. Closing of the ReadChannel should be done by what ever
> created it because it might need to be reused.
> If this not possible, an alternative could be to add a method
> {{ArrowReader.end()}} that will close resources but not the ReadChannel.
> Then {{end()}} could be called instead of {{close()}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
