[ 
https://issues.apache.org/jira/browse/ARROW-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187521#comment-16187521
 ] 

ASF GitHub Bot commented on ARROW-1629:
---------------------------------------

Github user pcmoritz commented on the issue:

    https://github.com/apache/arrow/pull/1151
  
    +1 the plasma related changes look good to me! I'm very glad it caught the 
memory leak.
    
    I'd like to do some modernizations on the Plasma code base, in particular 
getting rid of fling and using explicit MemoryMappedFile from 
https://github.com/apache/arrow/blob/84e5e02fbf412c979387b0a53b0ad0c6d5c5e790/cpp/src/arrow/io/file.h
 instead of shipping file descriptors between processes; this will make it 
harder to do the cleanups properly since we cannot rely on the reference 
counting from the OS any more to clean the files up after they are not used by 
anyone any more, but it will make it possible to have a native Java client and 
potentially other native bindings. I wonder what your thoughts on this tradeoff 
are.


> [C++] Fix problematic code paths identified by infer tool
> ---------------------------------------------------------
>
>                 Key: ARROW-1629
>                 URL: https://issues.apache.org/jira/browse/ARROW-1629
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> I'm making a pass over the output from ARROW-1626



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to