[
https://issues.apache.org/jira/browse/ARROW-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193830#comment-16193830
]
ASF GitHub Bot commented on ARROW-1540:
---------------------------------------
GitHub user wesm opened a pull request:
https://github.com/apache/arrow/pull/1181
ARROW-1540: Add NO_VALGRIND option to ADD_ARROW_TEST and disable valgrind
in a few problematic tests
It turns out that using valgrind with CUDA out of the box just doesn't work
that well. There were a couple other tests that fail in some valgrind setups so
I disabled those, too. Everything else should valgrind cleanly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wesm/arrow ARROW-1540
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1181
----
commit cda49c3558c93123e4322fe18fe639af972e2188
Author: Wes McKinney <[email protected]>
Date: 2017-10-05T22:12:41Z
Add NO_VALGRIND option to ADD_ARROW_TEST so certain tests can be excluded
from valgrind-enabled runs
Change-Id: Ic463c539c451dfd807c4487f2df012fda4a1790a
----
> [C++] Fix valgrind warnings in cuda-test if possible
> ----------------------------------------------------
>
> Key: ARROW-1540
> URL: https://issues.apache.org/jira/browse/ARROW-1540
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Running cuda-test with {{-DARROW_TEST_MEMCHECK=on}} fails with RC0. Not a big
> issue for 0.7.0 but may be worth investigating
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
