[
https://issues.apache.org/jira/browse/ARROW-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197998#comment-16197998
]
ASF GitHub Bot commented on ARROW-1488:
---------------------------------------
GitHub user wesm opened a pull request:
https://github.com/apache/arrow/pull/1191
ARROW-1488: [C++] Implement ArrayBuilder::Finish in terms of FinishInternal
based on ArrayData
I don't have strong feelings about the function names here, but this was
backwards compatible and will prevent extra box-then-unbox steps in analytics
code that utilizes builders for accumulating outputs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wesm/arrow ARROW-1488
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1191
----
commit 5313cab24a784170a846786b0c2ed447e16cf410
Author: Wes McKinney <[email protected]>
Date: 2017-10-09T22:26:23Z
Initial hack at refactoring Finish methods to return ArrayData
Change-Id: I5cddd2461c37232be3d99f91ab4f0dbafb886605
commit 0c23ff530679d96ae16e36bcc2d63a7ed5a5119f
Author: Wes McKinney <[email protected]>
Date: 2017-10-10T01:20:20Z
Rename Finish with ArrayData to FinishInternal
Change-Id: If8b33da048fa7e49fbfdb370ff4da0a0e75522a5
----
> [C++] Implement ArrayBuilder::Finish in terms of internal::ArrayData
> --------------------------------------------------------------------
>
> Key: ARROW-1488
> URL: https://issues.apache.org/jira/browse/ARROW-1488
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> In {{arrow::compute}} we will frequently be working with unboxed internal
> array data, so it would be useful for the builders to be able to return the
> internal data container. This may also simplify some code in arrow/builder.cc
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
