[
https://issues.apache.org/jira/browse/ARROW-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205094#comment-16205094
]
ASF GitHub Bot commented on ARROW-1652:
---------------------------------------
Github user trxcllnt commented on the issue:
https://github.com/apache/arrow/pull/1200
@wesm yep we have coverage [ready to
go](https://github.com/apache/arrow/blob/master/js/package.json#L21), but
[commented
out](https://github.com/apache/arrow/blob/master/ci/travis_script_js.sh#L28) in
the CI script until we set up something like coveralls.
@TheNeuralBit sorry I haven't responded to your comments on
[1652](https://issues.apache.org/jira/browse/ARROW-1652) yet, I'll do that
right now.
> [JS] Batch hint for Vector.get
> ------------------------------
>
> Key: ARROW-1652
> URL: https://issues.apache.org/jira/browse/ARROW-1652
> Project: Apache Arrow
> Issue Type: Improvement
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Paul Taylor
> Labels: Performance, pull-request-available
>
> The {{Vector.get}} function just accepts an index, and looks up the
> appropriate record batch on every call. This can lead to a lot of additional
> lookups when iterating by index. It would be nice if {{Vector.get}} accepted
> an optional batch hint, similar to
> [{{Vector.range}}|https://github.com/apache/arrow/blob/master/js/src/vector/typed.ts#L51]
> Additionally, if {{Table}} had some knowledge of the batches in its Vectors,
> it could use this batch hint to improve performance when iterating over rows.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
