[
https://issues.apache.org/jira/browse/ARROW-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206849#comment-16206849
]
ASF GitHub Bot commented on ARROW-1474:
---------------------------------------
Github user siddharthteotia commented on the issue:
https://github.com/apache/arrow/pull/1203
@BryanCutler,
I have addressed most of your general comments. Few points on remaining
comments
**(1) Regarding Logger** - I had added this as a TODO in my previous patch.
The thing is that we really don't log much. We only log in the base class
during realloc and alloc functions where there is a chance of catching memory
related exceptions. So I have been contemplating if we really need logging.
It's more of an unnecessary heap overhead.
The reason I initialize the specific logger in each subclass is because
when the super class methods dump out log messages we can see which exact
vector type the messages correspond to.
But again, since we barely log messages, I think we are better off not
having any logging at all. You can take a look at BaseNullableFixedWidthVector
and see what you think. Can we afford no logging?
https://github.com/apache/arrow/commit/60a2ebdfc9164d2405f9656030dedfbf789997b5#diff-dddca025d8d6792d8776d3c59ce508f7R270
(2) **Regarding FieldReader** -- I think you are right. When we are working
with a vector type, we have enough information available to create the reader
on demand as opposed to carrying the FieldReader object inside each vector. Is
this what you were suggesting?
However, we may have to see the impact of changes. This is definitely
doable but we will have to refactor code in map, list and union vectors where
when they read nested scalar vectors, they can no longer make a call to
getReader().
> [JAVA] ValueVector hierarchy (Implementation Phase 2)
> -----------------------------------------------------
>
> Key: ARROW-1474
> URL: https://issues.apache.org/jira/browse/ARROW-1474
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
