[ 
https://issues.apache.org/jira/browse/ARROW-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213597#comment-16213597
 ] 

ASF GitHub Bot commented on ARROW-507:
--------------------------------------

GitHub user wesm opened a pull request:

    https://github.com/apache/arrow/pull/1224

    ARROW-507: [C++] Complete ListArray::FromArrays implementation, add unit 
tests

    In the event that the offsets array has nulls, this will backward-fill the 
offsets to compute the correct value sizes.
    
    I left one TODO which is to possibly create a new validity bitmap with the 
last offset bit zero'd out (since the offsets array is one longer than the 
length of the created array, and it must be non-null). I might go ahead and do 
that

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wesm/arrow ARROW-507

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/arrow/pull/1224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1224
    
----
commit d99c0dfa0dcd311f9ea7c80de8b1e47d3ba5824b
Author: Wes McKinney <[email protected]>
Date:   2017-10-20T20:43:32Z

    Complete C++ implementation, unit test for ListArray::FromArrays, handling 
of offsets with nulls
    
    Change-Id: I89ef1dccbf101fcfdd56e3d7bc0d19e78842140d

commit 868a727a080afd0747c812fd082127afb57c1560
Author: Wes McKinney <[email protected]>
Date:   2017-10-21T00:36:26Z

    Implement / add tests for ListArray.from_arrays in Python
    
    Change-Id: I75e1123193d3a35ad788380405fc2d31e5511eba

----


> [C++/Python] Construct List container from offsets and values subarrays
> -----------------------------------------------------------------------
>
>                 Key: ARROW-507
>                 URL: https://issues.apache.org/jira/browse/ARROW-507
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: C++, Python
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> This is the inverse operation from flattening a list type into its child 
> values (dropping the offsets)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to