[
https://issues.apache.org/jira/browse/ARROW-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213648#comment-16213648
]
ASF GitHub Bot commented on ARROW-1671:
---------------------------------------
GitHub user wesm opened a pull request:
https://github.com/apache/arrow/pull/1227
ARROW-1671: [C++] Deprecate arrow::MakeArray that returns Status, refactor
existing code to new variant
We should be very strict to not return Status from functions that cannot
fail
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wesm/arrow ARROW-1671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1227
----
commit 8a15a068c05078ff41d8166b775a061e212766e6
Author: Wes McKinney <[email protected]>
Date: 2017-10-21T01:39:52Z
Deprecate arrow::MakeArray that returns Status, refactor existing code to
use new MakeArray returning std::shared_ptr<Array>
Change-Id: I2d005e8b3a3836a58182a7b2167ab955ab723ac3
----
> [C++] Change arrow::MakeArray to not return Status
> --------------------------------------------------
>
> Key: ARROW-1671
> URL: https://issues.apache.org/jira/browse/ARROW-1671
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> It should not be possible for this function to fail. We can do a DCHECK
> internally of any internal Status values for testing purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
