[
https://issues.apache.org/jira/browse/ARROW-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214507#comment-16214507
]
ASF GitHub Bot commented on ARROW-1087:
---------------------------------------
wesm commented on a change in pull request #1219: ARROW-1087: [Python] Add
pyarrow.get_include function. Bundle includes in all builds
URL: https://github.com/apache/arrow/pull/1219#discussion_r146153016
##########
File path: python/CMakeLists.txt
##########
@@ -226,9 +226,11 @@ function(bundle_arrow_implib library_path)
COPYONLY)
endfunction(bundle_arrow_implib)
+# Always bundle includes
+file(COPY ${ARROW_INCLUDE_DIR}/arrow DESTINATION
${BUILD_OUTPUT_ROOT_DIRECTORY}/include)
Review comment:
Yes, in fact this is a "fix" so that a conda-installed version of pyarrow
can be used in another project's setup.py (since `pyarrow.get_include()` will
need to work both in pip and conda)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] add get_include to expose directory containing header files
> --------------------------------------------------------------------
>
> Key: ARROW-1087
> URL: https://issues.apache.org/jira/browse/ARROW-1087
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Jacob Scott
> Assignee: Wes McKinney
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> {{numpy.get_include}} streamlines extension development:
> {code}
> import numpy as np
> ...
> Extension('extension_name', ...
> include_dirs=[np.get_include()])
> {code}
> It would be nice if pyarrow had the same thing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
