[
https://issues.apache.org/jira/browse/ARROW-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216098#comment-16216098
]
ASF GitHub Bot commented on ARROW-1588:
---------------------------------------
cpcloud commented on issue #1211: ARROW-1588: [C++/Format] Harden Decimal Format
URL: https://github.com/apache/arrow/pull/1211#issuecomment-338830640
Just to clarify from ARROW-1716 the integration tests pass because the
interpretation of decimal bytes isn't being checked in the integration tests,
so the bytes compare equal but if we were to print the value as the underlying
big integer or int128 in c++ and compare those they would be different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++/Format] Harden Decimal Format
> ----------------------------------
>
> Key: ARROW-1588
> URL: https://issues.apache.org/jira/browse/ARROW-1588
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Format
> Affects Versions: 0.7.0
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> We should finalize and harden the decimal format. The remaining issues are
> officially writing down the choice of making every decimal value 16 bytes and
> byte order.
> For byte order we'll need to run some benchmarks to compare little endian vs
> big endian. I plan to work on this over the next week or two.
> [[email protected]] [~wesmckinn] If there are any additional items you'd
> like to see addressed here please chime in.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
