[
https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218991#comment-16218991
]
ASF GitHub Bot commented on ARROW-1721:
---------------------------------------
wesm commented on a change in pull request #1246: ARROW-1721: [Python]
Implement null-mask check in places where it isn't supported in
numpy_to_arrow.cc
URL: https://github.com/apache/arrow/pull/1246#discussion_r146910978
##########
File path: cpp/src/arrow/python/numpy_to_arrow.cc
##########
@@ -1029,6 +1033,44 @@ Status LoopPySequence(PyObject* sequence, T func) {
return Status::OK();
}
+template <typename T>
+Status LoopPySequenceWithMasks(
+ PyObject* sequence,
+ const Ndarray1DIndexer<uint8_t>& mask_values,
+ bool have_mask,
+ T func
+) {
Review comment:
Can you run clang-format? (`make format` or `ninja format`). This should
also fix the cpplint failure in CI . See
https://github.com/apache/arrow/tree/master/cpp#continuous-integration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Support null mask in places where it isn't supported in
> numpy_to_arrow.cc
> ----------------------------------------------------------------------------------
>
> Key: ARROW-1721
> URL: https://issues.apache.org/jira/browse/ARROW-1721
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> see https://github.com/apache/spark/pull/18664#discussion_r146472109 for
> SPARK-21375
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
