[
https://issues.apache.org/jira/browse/ARROW-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219901#comment-16219901
]
ASF GitHub Bot commented on ARROW-1728:
---------------------------------------
wesm commented on issue #1251: ARROW-1728: [C++] Run clang-format checks in
Travis CI
URL: https://github.com/apache/arrow/pull/1251#issuecomment-339540207
Alright, we are looking good:
```
Scanning dependencies of target check-format
clang-format checks failed, run 'make format' to fix
make[3]: *** [CMakeFiles/check-format] Error 255
make[2]: *** [CMakeFiles/check-format.dir/all] Error 2
make[1]: *** [CMakeFiles/check-format.dir/rule] Error 2
make: *** [check-format] Error 2
```
I'll revert the flake and if others are in agreement about failing on
clang-format issues we can merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Run clang-format checks in Travis CI
> ------------------------------------------
>
> Key: ARROW-1728
> URL: https://issues.apache.org/jira/browse/ARROW-1728
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> I think it's reasonable to expect contributors to run clang-format on their
> code. This may lead to a higher number of failed builds but will eliminate
> noise diffs in unrelated patches
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
