[
https://issues.apache.org/jira/browse/ARROW-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223444#comment-16223444
]
ASF GitHub Bot commented on ARROW-1745:
---------------------------------------
xhochy closed pull request #1261: ARROW-1745: [Plasma] Include gtest after
plasma/compat.h in tests.
URL: https://github.com/apache/arrow/pull/1261
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/plasma/test/client_tests.cc
b/cpp/src/plasma/test/client_tests.cc
index 02b383214..0f19da5f7 100644
--- a/cpp/src/plasma/test/client_tests.cc
+++ b/cpp/src/plasma/test/client_tests.cc
@@ -15,8 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-#include "gtest/gtest.h"
-
#include <assert.h>
#include <signal.h>
#include <stdlib.h>
@@ -29,6 +27,8 @@
#include "plasma/plasma.h"
#include "plasma/protocol.h"
+#include "gtest/gtest.h"
+
namespace plasma {
std::string test_executable; // NOLINT
diff --git a/cpp/src/plasma/test/serialization_tests.cc
b/cpp/src/plasma/test/serialization_tests.cc
index 7c9d90133..b593b6ae9 100644
--- a/cpp/src/plasma/test/serialization_tests.cc
+++ b/cpp/src/plasma/test/serialization_tests.cc
@@ -15,8 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-#include "gtest/gtest.h"
-
#include <sys/types.h>
#include <unistd.h>
@@ -25,6 +23,8 @@
#include "plasma/plasma.h"
#include "plasma/protocol.h"
+#include "gtest/gtest.h"
+
namespace plasma {
/**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Compilation failure on Mac OS in plasma tests
> ---------------------------------------------
>
> Key: ARROW-1745
> URL: https://issues.apache.org/jira/browse/ARROW-1745
> Project: Apache Arrow
> Issue Type: Bug
> Components: Plasma (C++)
> Reporter: Robert Nishihara
> Assignee: Robert Nishihara
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
