[
https://issues.apache.org/jira/browse/ARROW-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226072#comment-16226072
]
ASF GitHub Bot commented on ARROW-1716:
---------------------------------------
BryanCutler commented on issue #1267: ARROW-1716: [Format/JSON] Use string
integer value for Decimals in JSON
URL: https://github.com/apache/arrow/pull/1267#issuecomment-340628007
Sure, I can look into it tomorrow
On Oct 30, 2017 5:41 PM, "Phillip Cloud" <[email protected]> wrote:
> @BryanCutler <https://github.com/bryancutler> Yep, that's right. The
> integration tests are currently failing. Can you help me out with making
> the changes to the Java codebase required to get the integration tests
> working again? I'm happy to keep digging, but this will go much faster if
> someone familiar with the Java side of things can give me a hand.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow/pull/1267#issuecomment-340626088>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AEUwdevvzpfRLzWUGuy0I5UPf1CaJUeQks5sxmzDgaJpZM4QKaYg>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Format/JSON] Use string integer value for Decimals in JSON
> -----------------------------------------------------------
>
> Key: ARROW-1716
> URL: https://issues.apache.org/jira/browse/ARROW-1716
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Java - Vectors
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Suprisingly, Java and C++ integration tests pass after ARROW-1588. This hides
> a bug, because we're writing decimal values as hex encoded bytes.
> C++ and Java compare that the bytes are the same, but because C++ is
> interpreting everything as little endian after ARROW-1588 and Java is big
> endian the numbers these bytes represent will be different in their
> respective systems.
> I propose that instead of encoding DecimaArray/DecimalVector values as hex
> encoded bytes, we store the integer as a string when writing Arrow
> DecimalArray/DecimalVector data to JSON. This will allow us to compare that
> the bytes have the same meaning in both systems.
> This requires a change to the way Arrow writes JSON.
> [~icexelloss] was extremely helpful in helping me get to the bottom of this.
> cc [~icexelloss] [~wesmckinn] [~jnadeau]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
