[
https://issues.apache.org/jira/browse/ARROW-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234363#comment-16234363
]
ASF GitHub Bot commented on ARROW-1652:
---------------------------------------
TheNeuralBit commented on a change in pull request #1273: ARROW-1652: [JS]
housekeeping, vector cleanup
URL: https://github.com/apache/arrow/pull/1273#discussion_r148275854
##########
File path: js/perf/index.js
##########
@@ -16,12 +16,10 @@
// under the License.
// Use the ES5 UMD target as perf baseline
-// ES6/7 iterators are faster in turbofan, but something about the
-// ES5 transpilation (rewriting let and const to var?) JITs better
-const { Table, readBuffers } = require('../dist/Arrow');
+// const { Table, readBuffers } = require('../targets/es5/umd');
// const { Table, readBuffers } = require('../targets/es5/cjs');
+const { Table, readBuffers } = require('../targets/es2015/umd');
// const { Table, readBuffers } = require('../targets/es2015/cjs');
Review comment:
Would it be possible to run perf tests on each target automatically like the
unit tests? Obviously doesn't need to happen now, just curious
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Separate Vector into BatchVector and CompositeVector
> ---------------------------------------------------------
>
> Key: ARROW-1652
> URL: https://issues.apache.org/jira/browse/ARROW-1652
> Project: Apache Arrow
> Issue Type: Improvement
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Paul Taylor
> Priority: Major
> Labels: Performance, pull-request-available
>
> CompositeVector should have a {{batch(..)}} function that returns a
> BatchVector
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
