[
https://issues.apache.org/jira/browse/ARROW-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237078#comment-16237078
]
ASF GitHub Bot commented on ARROW-1766:
---------------------------------------
kou commented on a change in pull request #1279: ARROW-1766: [GLib] Fix failing
builds on OSX
URL: https://github.com/apache/arrow/pull/1279#discussion_r148709334
##########
File path: ci/travis_before_script_c_glib.sh
##########
@@ -100,7 +100,7 @@ if [ $BUILD_SYSTEM = "autotools" ]; then
./configure $CONFIGURE_OPTIONS
- make -j4
+ ARCHFLAGS="-arch x86_64" make -j4
Review comment:
It's better that we specify `ARCHFLAGS` only on macOS like the following:
```sh
if [ $TRAVIS_OS_NAME = "osx" ]; then
ARCHFLAGS="-arch x86_64" make -j4
else
make -j4
fi
```
Because it's needless for other platforms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [GLib] Fix failing builds on OSX
> --------------------------------
>
> Key: ARROW-1766
> URL: https://issues.apache.org/jira/browse/ARROW-1766
> Project: Apache Arrow
> Issue Type: Bug
> Components: GLib
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
