[
https://issues.apache.org/jira/browse/ARROW-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238932#comment-16238932
]
ASF GitHub Bot commented on ARROW-1209:
---------------------------------------
xhochy commented on a change in pull request #1026: ARROW-1209: [C++] [WIP]
Support for reading avro from an AvroFileReader
URL: https://github.com/apache/arrow/pull/1026#discussion_r148928462
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -645,6 +646,58 @@ endif()
if (ARROW_AVRO)
# ----------------------------------------------------------------------
+ # Jansson
+ if("${JANNSON_HOME}" STREQUAL "")
+ set(JANNSON_PREFIX
"${CMAKE_CURRENT_BINARY_DIR}/jannson_ep/src/jannson_ep-install")
+ set(JANNSON_HOME "${JANNSON_PREFIX}")
+ set(JANNSON_INCLUDE_DIR "${JANNSON_PREFIX}/include")
+ if (MSVC)
+ set(JANNSON_STATIC_LIB_NAME jannson_static)
+ else()
+ set(JANNSON_STATIC_LIB_NAME jannson)
+ endif()
+ set(JANNSON_STATIC_LIB
"${JANNSON_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${JANNSON_STATIC_LIB_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}")
+ set(JANNSON_SRC_URL
"http://www.digip.org/jansson/releases/jansson-${JANNSON_VERSION}.tar.gz";)
+
+ if (${UPPERCASE_BUILD_TYPE} EQUAL "RELEASE")
+ if (APPLE)
+ set(JANNSON_CXXFLAGS "CXXFLAGS='-DNDEBUG -O1'")
Review comment:
Why this differentiation? Maybe copy/paste from snappy? (There we need this
because of a compiler bug).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Implement converter between Arrow record batches and Avro records
> -----------------------------------------------------------------------
>
> Key: ARROW-1209
> URL: https://issues.apache.org/jira/browse/ARROW-1209
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.0
>
>
> This would be useful for streaming systems that need to consume or produce
> Avro in C/C++
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
