[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239168#comment-16239168
 ] 

Li Jin commented on ARROW-1694:
-------------------------------

I don't think this is a bug. From my understanding, dictionary vectors should 
be kept open if the reader is open. Closing the root here:
https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/file/json/JsonFileReader.java#L154

will close the dictionary vectors.

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --------------------------------------------------------------------------
>
>                 Key: ARROW-1694
>                 URL: https://issues.apache.org/jira/browse/ARROW-1694
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>            Reporter: Ted Yu
>            Priority: Minor
>             Fix For: 0.8.0
>
>
> {code}
>       VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>       read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to