[
https://issues.apache.org/jira/browse/ARROW-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239169#comment-16239169
]
ASF GitHub Bot commented on ARROW-1756:
---------------------------------------
wesm commented on a change in pull request #1276: ARROW-1756: [Python] Fix
large file read/write error
URL: https://github.com/apache/arrow/pull/1276#discussion_r148938907
##########
File path: cpp/src/arrow/io/file.cc
##########
@@ -22,6 +22,21 @@
#define _FILE_OFFSET_BITS 64
+// define max read/write count
+#if defined(_MSC_VER)
+#define ARROW_IO_MAX_CONUT INT32_MAX
+#else
+
+#ifdef __APPLE__
+// due to macOS bug, we need to set read/write max
+#define ARROW_IO_MAX_CONUT INT32_MAX
+#else
+// see notes on Linux read/write manpage
+#define ARROW_IO_MAX_CONUT 0x7ffff000
Review comment:
Typos in these defines, I will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Observed int32 overflow in Feather write/read path
> -----------------------------------------------------------
>
> Key: ARROW-1756
> URL: https://issues.apache.org/jira/browse/ARROW-1756
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Wes McKinney
> Assignee: Licht Takeuchi
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> See downstream report
> https://github.com/wesm/feather/issues/321
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
