[
https://issues.apache.org/jira/browse/ARROW-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239648#comment-16239648
]
ASF GitHub Bot commented on ARROW-1750:
---------------------------------------
cpcloud commented on a change in pull request #1283: ARROW-1750: [C++] Remove
the need for arrow/util/random.h
URL: https://github.com/apache/arrow/pull/1283#discussion_r148963466
##########
File path: cpp/src/arrow/array-test.cc
##########
@@ -272,6 +274,24 @@ class TestPrimitiveBuilder : public TestBuilder {
vector<uint8_t> valid_bytes_;
};
+/// \brief uint8_t isn't a valid template parameter to
uniform_int_distribution, so
+/// we use SampleType to determine which kind of integer to use to sample.
+template <typename T,
+ typename = typename std::enable_if<std::is_integral<T>::value,
T>::type>
+struct SampleType {
Review comment:
I'm going to rename this to `UniformIntSampleType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Remove the need for arrow/util/random.h
> ---------------------------------------------
>
> Key: ARROW-1750
> URL: https://issues.apache.org/jira/browse/ARROW-1750
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The C++ stdlib provides APIs for everything this is currently being used for.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
