[
https://issues.apache.org/jira/browse/ARROW-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246228#comment-16246228
]
ASF GitHub Bot commented on ARROW-1717:
---------------------------------------
siddharthteotia commented on issue #1290: ARROW-1717: Refactor JsonReader
URL: https://github.com/apache/arrow/pull/1290#issuecomment-343248851
LGTM.
My two cents:
We should be little careful of adding patches to refactor branch since that
essentially requires to grab and retest the changes downstream with Dremio.
Currently there are two patches in refactor branch and there is a 3rd one
coming in (changes that were discovered as part of testing in Dremio). So there
is a good chance of conflict as well.
My suggestion is that if there is some cleanup necessary, it can easily be
done after refactor branch is merged into master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Remove public static helper method in vector classes for
> JSONReader/Writer
> ---------------------------------------------------------------------------------
>
> Key: ARROW-1717
> URL: https://issues.apache.org/jira/browse/ARROW-1717
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Li Jin
> Assignee: Li Jin
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
