[
https://issues.apache.org/jira/browse/ARROW-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252910#comment-16252910
]
ASF GitHub Bot commented on ARROW-1559:
---------------------------------------
wesm commented on a change in pull request #1266: ARROW-1559: [C++] Add Unique
kernel and refactor DictionaryBuilder to be a stateful kernel
URL: https://github.com/apache/arrow/pull/1266#discussion_r151027570
##########
File path: cpp/src/arrow/compute/kernels/cast.h
##########
@@ -60,7 +63,12 @@ Status Cast(FunctionContext* context, const Array& array,
const std::shared_ptr<DataType>& to_type, const CastOptions&
options,
std::shared_ptr<Array>* out);
+ARROW_EXPORT
+Status Cast(FunctionContext* context, const Datum& value,
+ const std::shared_ptr<DataType>& to_type, const CastOptions&
options,
+ Datum* out);
+
} // namespace compute
} // namespace arrow
-#endif // ARROW_COMPUTE_CAST_H
+#endif // ARROW_COMPUTE_KERNELS_CAST_H
Review comment:
I probably need to do a once over of Cast and make sure the ChunkedArray
form also works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Kernel implementations for "unique" (compute distinct elements of array)
> ------------------------------------------------------------------------------
>
> Key: ARROW-1559
> URL: https://issues.apache.org/jira/browse/ARROW-1559
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Assignee: Uwe L. Korn
> Labels: Analytics, pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
