[
https://issues.apache.org/jira/browse/ARROW-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253365#comment-16253365
]
ASF GitHub Bot commented on ARROW-1810:
---------------------------------------
xhochy closed pull request #1320: ARROW-1810: [Plasma] Remove unused Plasma
test shell scripts
URL: https://github.com/apache/arrow/pull/1320
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/plasma/test/run_tests.sh b/cpp/src/plasma/test/run_tests.sh
deleted file mode 100644
index 958bd0839..000000000
--- a/cpp/src/plasma/test/run_tests.sh
+++ /dev/null
@@ -1,61 +0,0 @@
-#!/usr/bin/env bash
-
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-# Cause the script to exit if a single command fails.
-set -e
-
-./src/plasma/plasma_store -s /tmp/plasma_store_socket_1 -m 0 &
-sleep 1
-./src/plasma/manager_tests
-killall plasma_store
-./src/plasma/serialization_tests
-
-# Start the Redis shards.
-./src/common/thirdparty/redis/src/redis-server --loglevel warning --loadmodule
./src/common/redis_module/libray_redis_module.so --port 6379 &
-redis_pid1=$!
-./src/common/thirdparty/redis/src/redis-server --loglevel warning --loadmodule
./src/common/redis_module/libray_redis_module.so --port 6380 &
-redis_pid2=$!
-sleep 1
-
-# Flush the redis server
-./src/common/thirdparty/redis/src/redis-cli flushall
-# Register the shard location with the primary shard.
-./src/common/thirdparty/redis/src/redis-cli set NumRedisShards 1
-./src/common/thirdparty/redis/src/redis-cli rpush RedisShards 127.0.0.1:6380
-sleep 1
-./src/plasma/plasma_store -s /tmp/store1 -m 1000000000 &
-plasma1_pid=$!
-./src/plasma/plasma_manager -m /tmp/manager1 -s /tmp/store1 -h 127.0.0.1 -p
11111 -r 127.0.0.1:6379 &
-plasma2_pid=$!
-./src/plasma/plasma_store -s /tmp/store2 -m 1000000000 &
-plasma3_pid=$!
-./src/plasma/plasma_manager -m /tmp/manager2 -s /tmp/store2 -h 127.0.0.1 -p
22222 -r 127.0.0.1:6379 &
-plasma4_pid=$!
-sleep 1
-
-./src/plasma/client_tests
-
-kill $plasma4_pid
-kill $plasma3_pid
-kill $plasma2_pid
-kill $plasma1_pid
-kill $redis_pid1
-wait $redis_pid1
-kill $redis_pid2
-wait $redis_pid2
diff --git a/cpp/src/plasma/test/run_valgrind.sh
b/cpp/src/plasma/test/run_valgrind.sh
deleted file mode 100644
index 047219412..000000000
--- a/cpp/src/plasma/test/run_valgrind.sh
+++ /dev/null
@@ -1,27 +0,0 @@
-#!/usr/bin/env bash
-
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-# Cause the script to exit if a single command fails.
-set -e
-
-./src/plasma/plasma_store -s /tmp/plasma_store_socket_1 -m 0 &
-sleep 1
-valgrind --leak-check=full --error-exitcode=1 ./src/plasma/manager_tests
-killall plasma_store
-valgrind --leak-check=full --error-exitcode=1 ./src/plasma/serialization_tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Plasma] Remove test shell scripts
> ----------------------------------
>
> Key: ARROW-1810
> URL: https://issues.apache.org/jira/browse/ARROW-1810
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Plasma (C++)
> Reporter: Philipp Moritz
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The shell scripts in
> https://github.com/apache/arrow/tree/master/cpp/src/plasma/test are not used,
> all tests are run via cmake, so we should remove them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
