[
https://issues.apache.org/jira/browse/ARROW-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254925#comment-16254925
]
ASF GitHub Bot commented on ARROW-1826:
---------------------------------------
siddharthteotia opened a new pull request #1325: ARROW-1826: [JAVA] Avoid
branching in copyFrom for fixed width scalars
URL: https://github.com/apache/arrow/pull/1325
cc @jacques-n , @BryanCutler , @icexelloss
Note: there was no performance regression or different behavior introduced
as part of refactor patches.
This is something I had noticed in the old code during refactoring but lost
track of it. copyFrom function for fixed width scalars does a double check if
the cell in the source vector is NULL or not. The old code used to do the same.
There is a straightforward way to avoid double check but the new changes
avoid branch all-together; since it is fine to copy garbage from source vector
as long as the validity bit is copied correctly to indicate NULL or non-NULL
value in the target cell.
Will add unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] Avoid branching at cell level (copyFrom)
> -----------------------------------------------
>
> Key: ARROW-1826
> URL: https://issues.apache.org/jira/browse/ARROW-1826
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Siddharth Teotia
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
