[
https://issues.apache.org/jira/browse/ARROW-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256201#comment-16256201
]
ASF GitHub Bot commented on ARROW-1829:
---------------------------------------
robertnishihara commented on issue #1317: ARROW-1829: [Plasma] Fixes to
eviction policy.
URL: https://github.com/apache/arrow/pull/1317#issuecomment-345107682
@pcmoritz I'm not sure I can actually find a case where the original code
behaves incorrectly. However, the memory bookkeeping is wrong. For example, we
only update `memory_used_` when `require_space` is called, but it should be
updated whenever an object is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Plasma] Clean up eviction policy bookkeeping
> ---------------------------------------------
>
> Key: ARROW-1829
> URL: https://issues.apache.org/jira/browse/ARROW-1829
> Project: Apache Arrow
> Issue Type: Bug
> Components: Plasma (C++)
> Reporter: Robert Nishihara
> Assignee: Robert Nishihara
> Labels: pull-request-available
>
> Currently, the eviction policy has a field {{memory_used_}} which keeps track
> of how much memory the store is currently using. However, this field is only
> updated when {{require_space}} is called, and it should be updated every time
> an object is created.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
