[
https://issues.apache.org/jira/browse/ARROW-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259627#comment-16259627
]
ASF GitHub Bot commented on ARROW-1808:
---------------------------------------
wesm commented on issue #1337: ARROW-1808: [C++] Make RecordBatch, Table
virtual interfaces for column access
URL: https://github.com/apache/arrow/pull/1337#issuecomment-345787659
@kou I fixed the glib compilation, but I added DCHECKs to the record batch
constructor to assert that the schema is the same size as the columns, but this
isn't being checked it seems in the Glib bindings:
```
TestFileWriter:
test_write_record_batch:
/home/wesm/code/arrow/cpp/src/arrow/record_batch.cc:39 Check failed:
(static_cast<int>(columns.size())) == (schema->num_fields())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Make RecordBatch interface virtual to permit record batches that
> lazy-materialize columns
> -----------------------------------------------------------------------------------------------
>
> Key: ARROW-1808
> URL: https://issues.apache.org/jira/browse/ARROW-1808
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> This should be looked at soon to prevent having to define a different virtual
> interface for record batches. There are places where we are using the record
> batch constructor directly, and in some third party code (like MapD), so this
> might be good to get done for 0.8.0
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
