[
https://issues.apache.org/jira/browse/ARROW-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260034#comment-16260034
]
ASF GitHub Bot commented on ARROW-1710:
---------------------------------------
BryanCutler commented on a change in pull request #1341: [WIP] ARROW-1710:
[Java] Remove Non-Nullable Vectors
URL: https://github.com/apache/arrow/pull/1341#discussion_r152143299
##########
File path: java/vector/src/test/java/org/apache/arrow/vector/TestBitVector.java
##########
@@ -426,81 +405,81 @@ public void testReallocAfterVectorTransfer2() {
public void testBitVector() {
// Create a new value vector for 1024 integers
try (final BitVector vector = new BitVector(EMPTY_SCHEMA_PATH, allocator))
{
- final BitVector.Mutator m = vector.getMutator();
vector.allocateNew(1024);
- m.setValueCount(1024);
+ vector.setValueCount(1024);
// Put and set a few values
- m.set(0, 1);
- m.set(1, 0);
- m.set(100, 0);
- m.set(1022, 1);
+ vector.set(0, 1);
+ vector.set(1, 0);
+ vector.set(100, 0);
+ vector.set(1022, 1);
- m.setValueCount(1024);
+ vector.setValueCount(1024);
- final BitVector.Accessor accessor = vector.getAccessor();
- assertEquals(1, accessor.get(0));
- assertEquals(0, accessor.get(1));
- assertEquals(0, accessor.get(100));
- assertEquals(1, accessor.get(1022));
+ assertEquals(1, vector.get(0));
+ assertEquals(0, vector.get(1));
+ assertEquals(0, vector.get(100));
+ assertEquals(1, vector.get(1022));
- assertEquals(1022, accessor.getNullCount());
+ assertEquals(1020, vector.getNullCount());
// test setting the same value twice
- m.set(0, 1);
- m.set(0, 1);
- m.set(1, 0);
- m.set(1, 0);
- assertEquals(1, accessor.get(0));
- assertEquals(0, accessor.get(1));
+ vector.set(0, 1);
+ vector.set(0, 1);
+ vector.set(1, 0);
+ vector.set(1, 0);
+ assertEquals(1, vector.get(0));
+ assertEquals(0, vector.get(1));
// test toggling the values
- m.set(0, 0);
- m.set(1, 1);
- assertEquals(0, accessor.get(0));
- assertEquals(1, accessor.get(1));
+ vector.set(0, 0);
+ vector.set(1, 1);
+ assertEquals(0, vector.get(0));
+ assertEquals(1, vector.get(1));
// should not change
- assertEquals(1022, accessor.getNullCount());
+ assertEquals(1020, vector.getNullCount());
- // Ensure unallocated space returns 0
- assertEquals(0, accessor.get(3));
+ // Ensure null value
+ assertTrue(vector.isNull(3));
// unset the previously set bits
- m.set(1, 0);
- m.set(1022, 0);
+ vector.setNull(0);
+ vector.setNull(1);
+ vector.setNull(100);
+ vector.setNull(1022);
Review comment:
again this seemed wrong before... since 4 values are set earlier, then all 4
should be unset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Decide what to do with non-nullable vectors in new vector class
> hierarchy
> ---------------------------------------------------------------------------------
>
> Key: ARROW-1710
> URL: https://issues.apache.org/jira/browse/ARROW-1710
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Li Jin
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> So far the consensus seems to be remove all non-nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
