[
https://issues.apache.org/jira/browse/ARROW-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260649#comment-16260649
]
Max Risuhin edited comment on ARROW-1836 at 11/21/17 12:28 PM:
---------------------------------------------------------------
[~wesmckinn] Could you please say, do you have an idea if it will be fine just
to completely remove definition of deprecated `static_visitor` struct from
[here|https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/variant.h#L105]
? Arrow compiles fine if it's removed.
If we need to keep deprecated constraints for compatibility reasons, it will
need to deprecated C4996 with pragmas directly in source code, since it's just
a warning about something deprecated was found by compiler.
was (Author: max risuhin):
[~wesmckinn] Could you please say, do you have an idea if it will be fine just
to completely remove definition of deprecated `static_visitor` struct from
[here|https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/variant.h#L105]
? Arrow compiles fine if it's removed.
If we need to keep deprecated constraints for compatibility reasons, it will
need to deprecated C4996 with pragmas directly in source code, since it's just
a warning that something deprecated was found by compiler.
> [C++] Fix C4996 warning from arrow/util/variant.h on MSVC builds
> ----------------------------------------------------------------
>
> Key: ARROW-1836
> URL: https://issues.apache.org/jira/browse/ARROW-1836
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Wes McKinney
> Assignee: Max Risuhin
> Fix For: 0.8.0
>
>
> [~Max Risuhin] can you look into this? This is leaking into downstream users
> of Arrow. see e.g.
> https://github.com/apache/parquet-cpp/pull/403/commits/8e40b7d7d8f161a14dfed70cb6d528e82ffa21a9
> and build failures
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/parquet-cpp/build/1.0.443
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
