[
https://issues.apache.org/jira/browse/ARROW-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263181#comment-16263181
]
ASF GitHub Bot commented on ARROW-1845:
---------------------------------------
wesm commented on a change in pull request #1348: ARROW-1845: [Python] Expose
Decimal128Type
URL: https://github.com/apache/arrow/pull/1348#discussion_r152656364
##########
File path: python/pyarrow/types.pxi
##########
@@ -967,7 +983,25 @@ cpdef DataType decimal(int precision, int scale=0):
decimal_type : DecimalType
"""
cdef shared_ptr[CDataType] decimal_type
- decimal_type.reset(new CDecimalType(precision, scale))
+ decimal_type.reset(new CDecimalType(byte_width, precision, scale))
+ return pyarrow_wrap_data_type(decimal_type)
Review comment:
`arrow::DecimalType` is the base type now -- I don't think we should allow
users to create instances of it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Expose Decimal128Type
> ------------------------------
>
> Key: ARROW-1845
> URL: https://issues.apache.org/jira/browse/ARROW-1845
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> In the course of the renaming, we forgot to update the Python code to the new
> {{Decimal128Type}}, thus master is currently failing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
