[
https://issues.apache.org/jira/browse/ARROW-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264674#comment-16264674
]
ASF GitHub Bot commented on ARROW-1758:
---------------------------------------
wesm commented on a change in pull request #1347: ARROW-1758: [Python] Remove
pickle=True option for object serialization
URL: https://github.com/apache/arrow/pull/1347#discussion_r152857909
##########
File path: python/pyarrow/serialization.py
##########
@@ -67,9 +68,11 @@ def _deserialize_default_dict(data):
serialization_context.register_type(
type(lambda: 0), "function",
- pickle=True)
+ custom_serializer=pickle.dumps, custom_deserializer=pickle.loads)
- serialization_context.register_type(type, "type", pickle=True)
+ serialization_context.register_type(type, "type",
+ custom_serializer=pickle.dumps,
+ custom_deserializer=pickle.loads)
Review comment:
This is sufficiently advanced stuff that I think it's not unreasonable to
ask people to explicitly use cloudpickle in a case like this. I would be OK if
we changed this patch to do that to get the build passing, and we can always
move on later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Remove pickle=True option for object serialization
> -----------------------------------------------------------
>
> Key: ARROW-1758
> URL: https://issues.apache.org/jira/browse/ARROW-1758
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Philipp Moritz
> Assignee: Licht Takeuchi
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> As pointed out in
> https://github.com/apache/arrow/pull/1272#issuecomment-340738439, we don't
> really need this option, it can already be done with pickle.dumps as the
> custom serializer and pickle.loads as the deserializer.
> This has the additional benefit that it will be very clear to the user which
> pickler will be used and the user can use a custom pickler easily.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
