[
https://issues.apache.org/jira/browse/ARROW-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265312#comment-16265312
]
ASF GitHub Bot commented on ARROW-1852:
---------------------------------------
wesm closed pull request #1352: ARROW-1852: [C++] Make retrieval of Plasma
manager fd a const operation
URL: https://github.com/apache/arrow/pull/1352
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/plasma/client.cc b/cpp/src/plasma/client.cc
index dd32bdc81..9bbafac38 100644
--- a/cpp/src/plasma/client.cc
+++ b/cpp/src/plasma/client.cc
@@ -617,7 +617,7 @@ Status PlasmaClient::Fetch(int num_object_ids, const
ObjectID* object_ids) {
return SendFetchRequest(manager_conn_, object_ids, num_object_ids);
}
-int PlasmaClient::get_manager_fd() { return manager_conn_; }
+int PlasmaClient::get_manager_fd() const { return manager_conn_; }
Status PlasmaClient::Info(const ObjectID& object_id, int* object_status) {
ARROW_CHECK(manager_conn_ >= 0);
diff --git a/cpp/src/plasma/client.h b/cpp/src/plasma/client.h
index 89df2b0b0..cfd11c16d 100644
--- a/cpp/src/plasma/client.h
+++ b/cpp/src/plasma/client.h
@@ -313,7 +313,7 @@ class ARROW_EXPORT PlasmaClient {
///
/// \return The file descriptor for the manager connection. If there is no
/// connection to the manager, this is -1.
- int get_manager_fd();
+ int get_manager_fd() const;
private:
/// This is a helper method for unmapping objects for which all references
have
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Plasma] Make retrieving manager file descriptor const
> ------------------------------------------------------
>
> Key: ARROW-1852
> URL: https://issues.apache.org/jira/browse/ARROW-1852
> Project: Apache Arrow
> Issue Type: Bug
> Components: Plasma (C++)
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
