[
https://issues.apache.org/jira/browse/ARROW-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265333#comment-16265333
]
ASF GitHub Bot commented on ARROW-1849:
---------------------------------------
wesm commented on a change in pull request #1351: ARROW-1849: [GLib] Add input
checks to GArrowRecordBatch
URL: https://github.com/apache/arrow/pull/1351#discussion_r152981597
##########
File path: c_glib/arrow-glib/record-batch.cpp
##########
@@ -152,7 +171,12 @@ garrow_record_batch_new(GArrowSchema *schema,
auto arrow_record_batch =
arrow::RecordBatch::Make(garrow_schema_get_raw(schema),
n_rows, arrow_columns);
- return garrow_record_batch_new_raw(&arrow_record_batch);
+ auto status = arrow_record_batch->Validate();
Review comment:
This also checks the schema types match the field types. If that becomes too
expensive we might add a faster validation function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [GLib] Add input checks to GArrowRecordBatch
> --------------------------------------------
>
> Key: ARROW-1849
> URL: https://issues.apache.org/jira/browse/ARROW-1849
> Project: Apache Arrow
> Issue Type: Improvement
> Components: GLib
> Reporter: Kouhei Sutou
> Assignee: Kouhei Sutou
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
