[ 
https://issues.apache.org/jira/browse/ARROW-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266185#comment-16266185
 ] 

ASF GitHub Bot commented on ARROW-1850:
---------------------------------------

wesm opened a new pull request #1363: ARROW-1850: [C++] Use void* / const void* 
for buffers in file APIs
URL: https://github.com/apache/arrow/pull/1363
 
 
   This makes for a more convenient / less rigid API without as need for as 
many usages of `reinterpret_cast<const uint8_t*>`. This does not impact 
downstream projects (e.g. parquet-cpp is unaffected) unless they provide 
implementations of these virtual interfaces. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [C++] Use const void* in Writable::Write instead of const uint8_t*
> ------------------------------------------------------------------
>
>                 Key: ARROW-1850
>                 URL: https://issues.apache.org/jira/browse/ARROW-1850
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> I noticed that {{Writable}} is also misspelled. This would spare the user 
> many usages of {{reinterpret_cast<const uint8_t*>(...)}}, and also will not 
> cause any explicit API breakage (except where users have overridden the 
> virtual function)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to