[
https://issues.apache.org/jira/browse/ARROW-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267721#comment-16267721
]
ASF GitHub Bot commented on ARROW-1710:
---------------------------------------
siddharthteotia commented on issue #1341: ARROW-1710: [Java] Remove
Non-Nullable Vectors
URL: https://github.com/apache/arrow/pull/1341#issuecomment-347352719
What are we doing with NonNullableMapVector, MapVector?
(1) Either we leave MapVector and NullableMapVector as is where the latter
is a subclass. In this case, there are no code changes needed in these two
modules.
OR
(2) We can combine them and just have a MapVector with a validity buffer.
I don't think there is a need to introduce a new class NonNullableMapVector
in the hierarchy.
My assumption with this patch was all nullables will become non-nullables
and we will get rid of FixedValueVectors.java template -- this is for scalars.
The only complex vector that has 2 different versions is MapVector and I
feel we can handle them in either of the two ways mentioned above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Remove non-nullable vectors in new vector class hierarchy
> -----------------------------------------------------------------
>
> Key: ARROW-1710
> URL: https://issues.apache.org/jira/browse/ARROW-1710
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Li Jin
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> So far the consensus seems to be remove all non-nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
