[
https://issues.apache.org/jira/browse/ARROW-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270989#comment-16270989
]
ASF GitHub Bot commented on ARROW-1869:
---------------------------------------
wesm closed pull request #1372: ARROW-1869: [JAVA] Fix LowCostIdentityHashMap
name
URL: https://github.com/apache/arrow/pull/1372
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/java/memory/src/main/java/org/apache/arrow/memory/AllocationManager.java
b/java/memory/src/main/java/org/apache/arrow/memory/AllocationManager.java
index 14687b546..419be3429 100644
--- a/java/memory/src/main/java/org/apache/arrow/memory/AllocationManager.java
+++ b/java/memory/src/main/java/org/apache/arrow/memory/AllocationManager.java
@@ -76,7 +76,7 @@
private final UnsafeDirectLittleEndian underlying;
// ARROW-1627 Trying to minimize memory overhead caused by previously used
IdentityHashMap
// see JIRA for details
- private final LowCostIdentityHasMap<BaseAllocator, BufferLedger> map = new
LowCostIdentityHasMap<>();
+ private final LowCostIdentityHashMap<BaseAllocator, BufferLedger> map = new
LowCostIdentityHashMap<>();
private final ReadWriteLock lock = new ReentrantReadWriteLock();
private final AutoCloseableLock readLock = new
AutoCloseableLock(lock.readLock());
private final AutoCloseableLock writeLock = new
AutoCloseableLock(lock.writeLock());
diff --git
a/java/memory/src/main/java/org/apache/arrow/memory/LowCostIdentityHasMap.java
b/java/memory/src/main/java/org/apache/arrow/memory/LowCostIdentityHashMap.java
similarity index 98%
rename from
java/memory/src/main/java/org/apache/arrow/memory/LowCostIdentityHasMap.java
rename to
java/memory/src/main/java/org/apache/arrow/memory/LowCostIdentityHashMap.java
index 1153fb593..fb7033815 100644
---
a/java/memory/src/main/java/org/apache/arrow/memory/LowCostIdentityHasMap.java
+++
b/java/memory/src/main/java/org/apache/arrow/memory/LowCostIdentityHashMap.java
@@ -28,7 +28,7 @@
* that provides "getKey" method
* @param <V>
*/
-public class LowCostIdentityHasMap<K, V extends ValueWithKeyIncluded<K>> {
+public class LowCostIdentityHashMap<K, V extends ValueWithKeyIncluded<K>> {
/*
* The internal data structure to hold values.
@@ -52,7 +52,7 @@
/**
* Creates an Map with default expected maximum size.
*/
- public LowCostIdentityHasMap() {
+ public LowCostIdentityHashMap() {
this(DEFAULT_MIN_SIZE);
}
@@ -63,7 +63,7 @@ public LowCostIdentityHasMap() {
* The estimated maximum number of entries that will be put in
* this map.
*/
- public LowCostIdentityHasMap(int maxSize) {
+ public LowCostIdentityHashMap(int maxSize) {
if (maxSize >= 0) {
this.size = 0;
threshold = getThreshold(maxSize);
@@ -96,7 +96,7 @@ private int computeElementArraySize() {
private Object[] newElementArray(int s) {
return new Object[s];
}
-
+
/**
* Removes all elements from this map, leaving it empty.
*
@@ -331,4 +331,4 @@ public V getNextValue() {
}
return null;
}
-}
\ No newline at end of file
+}
diff --git
a/java/memory/src/test/java/org/apache/arrow/memory/TestLowCostIdentityHasMap.java
b/java/memory/src/test/java/org/apache/arrow/memory/TestLowCostIdentityHashMap.java
similarity index 95%
rename from
java/memory/src/test/java/org/apache/arrow/memory/TestLowCostIdentityHasMap.java
rename to
java/memory/src/test/java/org/apache/arrow/memory/TestLowCostIdentityHashMap.java
index c1196147b..0237b3804 100644
---
a/java/memory/src/test/java/org/apache/arrow/memory/TestLowCostIdentityHasMap.java
+++
b/java/memory/src/test/java/org/apache/arrow/memory/TestLowCostIdentityHashMap.java
@@ -27,11 +27,11 @@
/**
* To test simplified implementation of IdentityHashMap
*/
-public class TestLowCostIdentityHasMap {
+public class TestLowCostIdentityHashMap {
@Test
public void testIdentityHashMap() throws Exception {
- LowCostIdentityHasMap<String, StringWithKey> hashMap = new
LowCostIdentityHasMap<>();
+ LowCostIdentityHashMap<String, StringWithKey> hashMap = new
LowCostIdentityHashMap<>();
StringWithKey obj1 = new StringWithKey("s1key", "s1value");
StringWithKey obj2 = new StringWithKey("s2key", "s2value");
@@ -88,7 +88,7 @@ public void testIdentityHashMap() throws Exception {
@Test
public void testLargeMap() throws Exception {
- LowCostIdentityHasMap<String, StringWithKey> hashMap = new
LowCostIdentityHasMap<>();
+ LowCostIdentityHashMap<String, StringWithKey> hashMap = new
LowCostIdentityHashMap<>();
String [] keys = new String[200];
for (int i = 0; i < 200; i++) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix typo in LowCostIdentityHashMap
> ----------------------------------
>
> Key: ARROW-1869
> URL: https://issues.apache.org/jira/browse/ARROW-1869
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Memory
> Affects Versions: 0.8.0
> Reporter: Ivan Sadikov
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Trivial fix for typo in LowCostIdentityHashMap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
