[ 
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271990#comment-16271990
 ] 

ASF GitHub Bot commented on ARROW-1866:
---------------------------------------

siddharthteotia commented on issue #1371: ARROW-1866: [Java] Combine MapVector 
classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#issuecomment-348053061
 
 
   Let us hold off making any changes to NullableMapVector and MapVector. I 
think this PR should just remove the newly added NonNullableMapVector class in 
the hierarchy and bring the hierarchy to the state it was before. 
   
   Meanwhile we can assess the usage of both types of vectors in Dremio and 
then document the changes (if any) required to these 2 vectors. 
   
   I don't think there is any harm in keeping these 2 vectors around for the 
time being. They are not breaking anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
>                 Key: ARROW-1866
>                 URL: https://issues.apache.org/jira/browse/ARROW-1866
>             Project: Apache Arrow
>          Issue Type: Sub-task
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed 
> as part of removing the non nullable vectors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to